Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added children prop to make typescript happy #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DroidZed
Copy link

@DroidZed DroidZed commented Oct 15, 2024

When I installed the package the typescript linter was spawning errors about the Menu component not accepting children.

When looked into the code, I noticed that the children prop was not found nor the Props interface was extending from the ViewProp interface to implicitly pass in the styles, testID, and children props.

A small fix was to have the children prop added to not clutter the auto completion for the component in the editor.

Also, the docs were mentioning the children prop being present while it's not. Please fix this asap.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant