Skip to content

Commit

Permalink
don't write ruff output to file (#121)
Browse files Browse the repository at this point in the history
* don't write ruff output to file

* Update ruff instructions in python README

---------

Co-authored-by: ok300 <[email protected]>
  • Loading branch information
ubbabeck and ok300 authored Jan 12, 2024
1 parent 686b57a commit 464a298
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ jobs:
- name: Check python formatting
working-directory: snippets/python/src
run: ruff --ignore F841 --ignore F401 --output-format=github .
run: ruff check --ignore F841 --ignore F401 --add-noqa .

- name: Check python syntax
working-directory: snippets/python
Expand Down
6 changes: 4 additions & 2 deletions snippets/python/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,15 @@ cd snippets/python
python3 -m compileall src
```

To check the snippet formatting:
To check the snippet against formatting and linter rules:

```bash
cd snippets/python/src
ruff --ignore F841 --ignore F401 --output-format=github .
ruff check --ignore F841 --ignore F401 --add-noqa .
```

and fix all occurrences of the `# noqa` directive.

To execute the snippets locally, in order to check for type correctness:

```bash
Expand Down

0 comments on commit 464a298

Please sign in to comment.