Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dart docs & use Title Case for titles #105

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Update Dart docs & use Title Case for titles #105

merged 2 commits into from
Nov 29, 2023

Conversation

erdemyerebasmaz
Copy link
Contributor

@erdemyerebasmaz erdemyerebasmaz commented Nov 28, 2023 •
edited
Loading

  • Use Title Case for titles
    • Add header to Service Status page, convert other headers to subheaders
  • Explicitly declare types instead of relying on Dart compiler
  • Extract ReportIssueRequest to a variable that'll be used on reportIssue
  • Add fenv config files to .gitignore
  • Update dependencies to latest

ubbabeck
ubbabeck approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@ubbabeck ubbabeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt 💯

@erdemyerebasmaz erdemyerebasmaz merged commit cd8f2bb into main Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubbabeck ubbabeck ubbabeck approved these changes

@dangeross dangeross Awaiting requested review from dangeross

@ok300 ok300 Awaiting requested review from ok300

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erdemyerebasmaz @ubbabeck