Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging section #170

Merged
merged 8 commits into from
Jun 21, 2024
Merged

Add logging section #170

merged 8 commits into from
Jun 21, 2024

Conversation

dangeross
Copy link
Contributor

This PR splits the Getting started section into separate pages and adds an Adding logging section

Copy link
Contributor

@erdemyerebasmaz erdemyerebasmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Made suggestions re: CI errors.

snippets/react-native/getting_started.ts Outdated Show resolved Hide resolved
snippets/csharp/GettingStarted.cs Outdated Show resolved Hide resolved
src/guide/connecting.md Outdated Show resolved Hide resolved
src/guide/logging.md Outdated Show resolved Hide resolved
Copy link
Contributor

@erdemyerebasmaz erdemyerebasmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dangeross dangeross merged commit 7ca6a2d into main Jun 21, 2024
69 checks passed
@dangeross dangeross deleted the savage-logging branch June 21, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants