Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handling multiple assets page #68

Merged
merged 6 commits into from
Feb 3, 2025
Merged

Add handling multiple assets page #68

merged 6 commits into from
Feb 3, 2025

Conversation

dangeross
Copy link
Contributor

No description provided.

@dangeross dangeross force-pushed the savage-asset-metadata branch 11 times, most recently from f8ef798 to 89ffe60 Compare January 22, 2025 15:33
roeierez
roeierez reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Commented about one concern I have.

src/guide/assets.md Show resolved Hide resolved
roeierez
roeierez approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dangeross dangeross force-pushed the savage-asset-metadata branch 2 times, most recently from faff528 to a30635f Compare January 29, 2025 10:25
@dangeross dangeross changed the base branch from main to yse-py-0.6.2 January 29, 2025 10:25
@dangeross dangeross force-pushed the savage-asset-metadata branch from a30635f to 06ee295 Compare January 30, 2025 17:25
@dangeross dangeross changed the base branch from yse-py-0.6.2 to pre-release February 3, 2025 13:47
@dangeross dangeross force-pushed the savage-asset-metadata branch from 06ee295 to c611c28 Compare February 3, 2025 14:49
@dangeross dangeross merged commit 04f9c1e into pre-release Feb 3, 2025
28 of 31 checks passed
@dangeross dangeross deleted the savage-asset-metadata branch February 3, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roeierez roeierez roeierez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dangeross @roeierez