Add test for PartialEq impl #58
Conversation
I agree to license my contributions to each file under the terms given at the top of each file I changed.
Thanks for contributing. Your PR was helpful, though indirectly and differently than what you intended. It prompted me to remove the Accordingly, this PR now doesn't make sense, so I'll close it. I will still review your PR line-by-line anyway in case you find the input helpful. |
| @@ -62,6 +62,24 @@ fn test_input_as_slice_less_safe() { | |||
| assert_eq!(input.as_slice_less_safe(), slice); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_input_equality() { | |||
| let slice1 = b"foo"; | |||
There was a problem hiding this comment.
In general I prefer to have tests that are "parameterized"; that is, where there is an explicit list of test inputs (and maybe expected result for each one, if the expected result isn't the same for all of them), where the test loops over the list of inputs. This way it is clearer to see what is being tested for each input. See recent PRs for an example of this style.
Part of #1. Adds test for equality operator overload.
Apologies if I'm doing something dumb - I'm coming from a C++ background and figured I should learn some Rust, and may as well try to contribute to the community while I learn.
I agree to license my contributions to each file under the terms given
at the top of each file I changed.