Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chat spacing and minor detail #135

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

AlexisKenAlvarez
Copy link
Collaborator

Before
image

After
image

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kabsudotme ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 5:33pm
kabsudotme-ngl ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 5:33pm

@aaronjoshuaespinosa
Copy link
Collaborator

this is a nice revision for the messages, improves readability!

Copy link
Collaborator

@tfudoinkebs tfudoinkebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! The update to the message structure significantly improves readability!

@aaronjoshuaespinosa
Copy link
Collaborator

aaronjoshuaespinosa commented Sep 18, 2024

I added information on the reply to know who replied and whose message was replied.

When someone replied to their own message:
image
other users reply.user_id matches with chat.user_id


When you replied to your own message:
image
your reply.user_id matches with current.user_id


When you reply to someone else:
image
the chat.user_id is different from current.user_id. this one still needs fixing, can't seem to make it work and i can't fetch it properly. pls send help.


When someone replied to you:
image
reply.user_is different from current.user_id. also need help with this one xd, "yourself" should be "you"

@aaronjoshuaespinosa
Copy link
Collaborator

Added a fix for the comment above

When someone replied to you:
image

When someone replied to their own message:
image

When you reply to your message:
image

When you reply to someone: (still need fixing for this one tho)
image

@bricesuazo
Copy link
Owner

Added a fix for the comment above

When someone replied to you: image

When someone replied to their own message: image

When you reply to your message: image

When you reply to someone: (still need fixing for this one tho) image

Please fix this first before I approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants