Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emoji picker #138

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

Emoji picker #138

wants to merge 9 commits into from

Conversation

tfudoinkebs
Copy link
Collaborator

Added Emoji Picker to Post & Comment Section:
image
image

Issues:

  • The post and comment forms don't instantly recognize emojis as valid input. You have to click the "Post" or "Comment" button for the button to become active.
  • Poor loading implementation when the emoji picker is clicked.
  • The emoji picker doesn't load immediately when clicked.

@tfudoinkebs tfudoinkebs added the bug Something isn't working label Sep 19, 2024
@tfudoinkebs tfudoinkebs self-assigned this Sep 19, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kabsudotme ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 6:50am
kabsudotme-ngl ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 6:50am

GabrielAstilla
GabrielAstilla reviewed Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@GabrielAstilla GabrielAstilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is good to be deployed in the staging environment. This also fixed the bug on profile pictures on the comment section.

@tfudoinkebs
- changed emoji-oicker-react to emoji-mart
2773d83 
- changed the maximum characters in MentionsInput to 512
- removed loader on emoji picker when clicked
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielAstilla GabrielAstilla GabrielAstilla approved these changes

@bricesuazo bricesuazo Awaiting requested review from bricesuazo

@AlexisKenAlvarez AlexisKenAlvarez Awaiting requested review from AlexisKenAlvarez

@aaronjoshuaespinosa aaronjoshuaespinosa Awaiting requested review from aaronjoshuaespinosa

@rodcotines rodcotines Awaiting requested review from rodcotines

Assignees

@tfudoinkebs tfudoinkebs

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tfudoinkebs @GabrielAstilla