Make align system more dynamic and user-friendly #277
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on great feedback from @mrosseel this is a PR to polish up the Align feature:
I tried to use the IMU during the entire process, but it made it much more confusing as the selection point would move to the star's location when the arrow was pressed, but this would almost alwasys be a little different in the next moment due to the imu motion from interacting with the PiFinder. This would make it seem like it was not selecting the star, but was slightly offset. Tying the location to the camera solve during star selection makes for a nicer experience as the selected star is well indicated and the set of stars is stable for selection.
To help guide the process and avoid user confusion, the chart starts dynamic using the IMU and shows the current alignment using the normal reticle pattern. A prompt is displayed along the bottom to guide the user through and should, hopefully, make the process more understandable.