Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[std] Add std.attachResources() recipe #146

Merged
merged 1 commit into from
Jan 20, 2025
Merged

[std] Add std.attachResources() recipe #146

merged 1 commit into from
Jan 20, 2025

Conversation

kylewlacy
Copy link
Member

Companion to brioche-dev/brioche#149

This PR adds a new std.attachResources() function. This returns a recipe corresponding to the new upstream attach_resources recipe type.

@kylewlacy
Copy link
Member Author

This PR should only be merged once the attach_resources recipe type has landed in a published Brioche release. The implementation in this PR currently asserts that std.attachResources() requires Brioche >= v0.1.4, which should be the first version to include this new recipe.

@kylewlacy kylewlacy mentioned this pull request Dec 21, 2024
Merged
@kylewlacy kylewlacy marked this pull request as ready for review January 20, 2025 01:47
@kylewlacy
Copy link
Member Author

Brioche v0.1.4 went out yesterday, so this should be ready to go now

@kylewlacy kylewlacy merged commit 9c04964 into main Jan 20, 2025
3 checks passed
@kylewlacy kylewlacy deleted the std-attach-resources branch January 20, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kylewlacy