Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made changes for SnapATAC2 v2.6.0 #1273

Merged
merged 22 commits into from
May 23, 2024
Merged

Made changes for SnapATAC2 v2.6.0 #1273

merged 22 commits into from
May 23, 2024

Conversation

ekiernan
Copy link
Contributor

Description

  • Updated the SnapATAC2 docker to include SnapATAC v2.6.0
  • Updated Multiome, ATAC, and PairedTag to be compatible with changes in SnapATAC2 v2.6.0

Checklist

If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP documentation team by tagging either @ekiernan or @kayleemathews in a comment on this PR.

  • Did you add inputs, outputs, or tasks to a workflow?
  • Did you modify, delete or move: file paths, file names, input names, output names, or task names?
  • If you made a changelog update, did you update the pipeline version number?

Copy link

Remember to squash merge!

Copy link

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not been changed and needs updating
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

Remember to squash merge!

Copy link

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not been changed and needs updating
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

Remember to squash merge!

Copy link

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not been changed and needs updating
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

Remember to squash merge!

Copy link

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not been changed and needs updating
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented May 3, 2024

Remember to squash merge!

Copy link

github-actions bot commented May 3, 2024

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not been changed and needs updating
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented May 3, 2024

Remember to squash merge!

Copy link

github-actions bot commented May 3, 2024

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not been changed and needs updating
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented May 6, 2024

Remember to squash merge!

Copy link

github-actions bot commented May 6, 2024

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not been changed and needs updating
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented May 9, 2024

Remember to squash merge!

Copy link

github-actions bot commented May 9, 2024

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not been changed and needs updating
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

Remember to squash merge!

Copy link

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not been changed and needs updating
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed

@ekiernan
Copy link
Contributor Author

retest this please

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Multiome.changelog.md has not been changed and needs to be updated
atac.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
Optimus.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
SlideSeq.wdl and SlideSeq.changelog.md do not have matching versions
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@ekiernan
Copy link
Contributor Author

Fragment file differences in paired-tag data are the result of sorting - when we sort the files, the md5sums match. For example, the BI015 sample: 54b66cf8c81392595a15c9480612a33d sorted.test.tsv
54b66cf8c81392595a15c9480612a33d sorted.truth.tsv

Copy link

Remember to squash merge!

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

@ekiernan
Copy link
Contributor Author

retest this please

@ekiernan ekiernan merged commit a22865d into develop May 23, 2024
11 checks passed
@ekiernan ekiernan deleted the lk-PD-2608-snapatac2 branch May 23, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants