Upgrade vr-imgui #64
Merged
Upgrade vr-imgui #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+25
to
+33
| if (x < min) | ||
| { | ||
| return min; | ||
| } | ||
| if (x > max) | ||
| { | ||
| return max; | ||
| } | ||
| return x; |
There was a problem hiding this comment.
Are you adding any extra functionality here? It's a little hard to tell in GitHub, just want to make sure you're not merging any changes you don't mean to
There was a problem hiding this comment.
Yes. Kind of new functionality. Updating imgui also implies upgrading the code in the transfer function widgets.
|
@RobertGemmaJr Sorry to be so late on this PR. Could you give it a new review? |
RobertGemmaJr
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes linking against the new vr-imgui that supports the latest imgui and the upgrading in transfer function widget.
Closes #49 and #48