Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add documentation for the new directory structure #103

Merged
merged 13 commits into from
Mar 1, 2024

Conversation

RobertGemmaJr
Copy link
Member

@RobertGemmaJr RobertGemmaJr commented Feb 26, 2024

  • Adds documentation for the new src/experiment/ folder
    • index.js and honeycomb.js
    • experiment/procedures/
    • experiment/trials/
  • Better explains how the honeycomb_.js files are for the example experiment and that the user should create their experiment in new files
  • Adjusts the documentation for the new organization of electron files
  • Better "tabs" the callouts so they're in line with the piece of documentation their talking about

@RobertGemmaJr RobertGemmaJr self-assigned this Feb 26, 2024
This was linked to issues Feb 26, 2024
@RobertGemmaJr RobertGemmaJr added the 3.3 Versioning: Issue in regards to version 3.3 release label Feb 26, 2024
@RobertGemmaJr
Copy link
Member Author

This is going to be a massive comment 😬
image
image
image
image
image
image

@RobertGemmaJr RobertGemmaJr requested a review from eldu February 26, 2024 20:10
Base automatically changed from second-pass to feat-v3.3 February 27, 2024 20:29
Copy link
Member

@tdivoll tdivoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Just a few little cleanups for consistency.

@@ -38,149 +38,184 @@ This folder contains different files used to pass environment variables (setting
## node_modules/

:::danger
`node_modules/` is written to when running `npm install` and should never be manually edited.
`node_modules/` is written to when running `npm install` and should never be edited. It is in Honeycomb's `.gitignore` and should never be added to git.
:::

## psiturkit/

The file `psiturk-it` inside `psiturkit/` is a bash script used to instal PsiTurk locally - see [PsiTurk](psiturk#build-instructions) for more information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you add the extension to this psiturk-it file to better distinguish between the file and the directory?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, I'm not to worried about it. Nobody really uses psiturk anymore and it's going to be deprecated in v4

docs/project_organization/directory_structure.mdx Outdated Show resolved Hide resolved
docs/project_organization/directory_structure.mdx Outdated Show resolved Hide resolved
docs/project_organization/directory_structure.mdx Outdated Show resolved Hide resolved
docs/project_organization/directory_structure.mdx Outdated Show resolved Hide resolved
docs/project_organization/directory_structure.mdx Outdated Show resolved Hide resolved
docs/project_organization/directory_structure.mdx Outdated Show resolved Hide resolved
@RobertGemmaJr RobertGemmaJr merged commit 05e6d52 into feat-v3.3 Mar 1, 2024
1 check passed
@RobertGemmaJr RobertGemmaJr deleted the ref-procedures branch March 1, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.3 Versioning: Issue in regards to version 3.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update folder hierarchy docs Refer to "blocks" as "procedures"
2 participants