Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clean up quick start steps for editing the task #114

Merged
merged 15 commits into from
Mar 18, 2024

Conversation

RobertGemmaJr
Copy link
Member

@RobertGemmaJr RobertGemmaJr commented Mar 11, 2024

Updates the quick start guide! Lots more screenshots I do apologize.

  • Adds 3steps under "Edit the Task"
  • Adds a separate step for creating a new file for updating the experiment/index.js file
  • Adds a separate step for adding the startProcedure and endProcedure to the new task
  • Adds a magic comment that highlight's lines in a code block red (tells the user to delete that line)

image
image
image
image
image

@RobertGemmaJr RobertGemmaJr self-assigned this Mar 11, 2024
@RobertGemmaJr RobertGemmaJr added the 3.3 Versioning: Issue in regards to version 3.3 release label Mar 11, 2024
@RobertGemmaJr RobertGemmaJr marked this pull request as ready for review March 12, 2024 14:48
docs/quick_start.mdx Outdated Show resolved Hide resolved
Now that the task is up and running we can make our first changes to the code! We'll edit the `package.json` file to reflect your information.
Now that the project is up and running we can make our first changes to the code!

### 1) Edit the Project Metadata

1. Create a new branch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to specify that this command is run in the Terminal and without killing the server?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, you could rerun it, but maybe folks need to be reminded that the server needs to be running constantly or else the app will close?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's okay to leave it as is. Either closing the server and changing branches or changing branches in a new terminal will work. We document that the npm run dev will reflect the changes immediately so whether or not they keep it running is up to them

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the text to say "Create a new branch in a separate terminal" which should help a little

docs/quick_start.mdx Outdated Show resolved Hide resolved
```

4. Create a [pull request](version_control#create-a-pull-request) to bring your changes into the `main` branch
10. Create and merge a [pull request](version_control#create-a-pull-request) to merge your changes into the `main` branch. Make sure the builds complete successfully before merging!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to give instructions on what it means to make sure the build completes successfully?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The builds are run as github actions and I think GitHub makes it pretty self explanatory if/when the actions fail and how to diagnose the issues. I'm toying around with the idea of writing a seperate GitHub Discussions post for working with the actions but I don't think that needs to be up before 3.3 gets released

Copy link
Contributor

@galenwinsor galenwinsor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just some nitpicky changes to language and questions about clarity.

RobertGemmaJr and others added 2 commits March 12, 2024 11:57
Co-authored-by: Galen Winsor <[email protected]>
Co-authored-by: Galen Winsor <[email protected]>
docs/quick_start.mdx Outdated Show resolved Hide resolved
docs/quick_start.mdx Outdated Show resolved Hide resolved
@RobertGemmaJr RobertGemmaJr merged commit fcd2937 into feat-v3.3 Mar 18, 2024
1 check passed
@RobertGemmaJr RobertGemmaJr deleted the ref-quick-start branch March 18, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.3 Versioning: Issue in regards to version 3.3 release
Projects
None yet
2 participants