Skip to content
This repository has been archived by the owner on Feb 11, 2025. It is now read-only.

fix adding sequence nodes #34

Merged
merged 7 commits into from
Oct 4, 2024
Merged

fix adding sequence nodes #34

merged 7 commits into from
Oct 4, 2024

Conversation

jashlu
Copy link
Collaborator

@jashlu jashlu commented Sep 30, 2024 •
edited
Loading

Previous #32 is too messed up, clean fresh branch here

Also address #18

(.venv) (base) jlu117@OIT2JF9D6R social_norms_trees % python ui_wrapper.py
AIT Prototype #1 Simulator

Loading behavior tree and behavior library from resources.json...

An error occured when loading resources for this experiment: 
There was an invalid configuration detected in the inputted behavior tree: Children were detected for Behavior type node 'Behavior G': Behavior nodes should not have any children. Please check the structure of your behavior tree.


Simulation has ended.

@jashlu jashlu requested a review from hollandjg October 2, 2024 15:13
@jashlu jashlu linked an issue Oct 3, 2024 that may be closed by this pull request
Bug: fix move/removing a sequence #17
Closed
@jashlu jashlu removed a link to an issue Oct 3, 2024
Bug: fix move/removing a sequence #17
Closed
@jashlu jashlu linked an issue Oct 3, 2024 that may be closed by this pull request
check: that we can add a sequence or selector to the library #21
Closed
@jashlu jashlu linked an issue Oct 3, 2024 that may be closed by this pull request
JSON parser: throw an error if a Type: Behavior node has children. #18
Closed
@jashlu jashlu marked this pull request as draft October 3, 2024 18:37
@jashlu jashlu requested review from hollandjg and removed request for hollandjg October 3, 2024 18:37
@jashlu jashlu marked this pull request as ready for review October 4, 2024 17:55
jashlu
jashlu commented Oct 4, 2024
View reviewed changes
src/social_norms_trees/ui_wrapper.py Outdated
@@ -155,9 +155,15 @@ def main():
#load tree to run experiment on, and behavior library

RESOURCES_FILE = "resources.json"
original_tree, behavior_library, context_paragraph = load_resources(RESOURCES_FILE)
try:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need to have try/except, fail here and allow error to end

hollandjg
hollandjg approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Base automatically changed from refactor-ui to main October 4, 2024 19:37
@jashlu jashlu merged commit 959ab09 into main Oct 4, 2024
8 checks passed
@jashlu jashlu deleted the fix-add-sequence branch October 4, 2024 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hollandjg hollandjg hollandjg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jashlu @hollandjg