-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cant use custom fonts #64
Open
xysedhasan
wants to merge
33
commits into
brucetoo:master
Choose a base branch
from
BlackBoxVision:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the code, and made some optimizations
- Refactor of DatePickerPopUpWindow - Modifications on WheelView - Better layout hierarchies on layouts.xml files - Refactor over sample app
- Extracting code for date formatting to DateUtils - Remove unused imports - Minor changes under sample app
- Extracting code to initialize monthSpinner and yearSpinner - Removed BitmapDrawable deprecated constructor for ColorDrawable
- Remove external interface LoopScrollListener - Moved LoopScrollListener to WheelView and renamed to OnLoopScrollListener - Rename method setLoopListener to setOnLoopScrollListener in order to get more consistence - OnLoopScrollListener callback was renamed to onLoopScrollFinish and takes two parameters, the object selected and the position. - Added interface ItemMapper with method map, this interface enables you to map any object to WheelView. - Added setter for itemMapper field - Added default itemMapper, object -> (String) object - Internal changes on DatePickerPopUpWindow to make code more clean, the DateUtils class methods are imported as statics
Added License and Android Arsenal badge
- Fix bug with days not setting correctly - Minor change in WheelView
- Refactor over WheelView attrs - Finished to create class DatePickerWheelView - Added some new methods to DateUtils
- Remove unused method toMilliseconds - Fixed issue with initial position on year
- Remove log calls in DateUtils parseDateString method - Added param locale to method formatDate of DateUtils - Added again support for Locale in DatePickerPopUpWindow - Simplified code around DatePickerWheelView, also removed prop isLoopEnabled, due to problems when circular iterating list. - Remove attr isLoopEnabled from attrs.xml
- Fix issue with indexOutOfBounds on when scrolling by month DatePickerWheelView - Set canLoop in WheelView to false as default value - Removed unused attributes under datepicker and datepicker inverted XML layouts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i need to use the custom font of text i cant do please help