Fix a crash in heuristic memory mapping. #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 712ed9b changed the way that the Sufami Turbo base cartridge was detected, but it caused crashes. Apparently the way we were converting the binary ROM data to a string for comparison, was actually calling the wrong `string` constructor. Let's more explicitly create a string_view instead of hoping for the compiler to pick a suitable constructor chain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 712ed9b changed the way that the Sufami Turbo base cartridge was detected, but it caused crashes. Apparently the way we were converting the binary ROM data to a string for comparison, was actually calling the wrong
stringconstructor. Let's more explicitly create a string_view instead of hoping for the compiler to pick a suitable constructor chain.