-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starting point for AOAI + OAI #5
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,9 @@ | |||
import "@typespec/versioning"; | |||
|
|||
@Versioning.versioned(OpenAIFlavors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I broke out the models into a separate, versioned namespace so the individual @service
-decorated namespaces could reference the specific version they needed.
versions.tsp
Outdated
|
||
enum OpenAIFlavors { | ||
OpenAI, | ||
Azure, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All models in Azure should be super-sets of OpenAI. And if they are not, we could accommodate that with marking them as @removed(OpenAIFlavors.Azure)
.
The outputs as provided in the PR are the result of |
- Fix issue in AssistantClient where `SubmitToolOutputsAsync` was not returning a `ThreadRun` as it should. - Add missing async sample for function calling - Clean up function calling samples to make them more genuine
Added starting point/skeleton for how we can include both Azure OpenAI and OpenAI endpoints in the same TSP compilation/set of files.
There are still many endpoints that need to be added on the Azure side/models to be augmented. But I'd like to get feedback on the approach first.