refactor: changed transaction handling related to Push package #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
pkg/push/api/api.gofile to refactor transaction handling and improve the push storage mechanism. The main changes involve replacing the old transaction methods with a new version and updating the push storage usage across various functions. Additionally, the test cases inpkg/push/api/api_test.gohave been updated to reflect these changes.Refactoring transaction handling and push storage:
pkg/push/api/api.go: Replaced the old transaction handling methods withRunInTransactionV2and updated the usage ofpushStorageacross multiple functions such asCreatePush,UpdatePush,DeletePush, andGetPush. [1] [2] [3] [4] [5] [6] [7]Updating test cases:
pkg/push/api/api_test.go: Modified the test cases to use the mockpushStorageand the new transaction handling methodRunInTransactionV2. This includes changes in functions likeTestCreatePushMySQL,TestCreatePushNoCommandMySQL, andTestUpdatePushMySQL. [1] [2] [3] [4] [5] [6] [7] [8]Part of #1474