-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add cla workflow #23
Conversation
Signed-off-by: Kenta Kozuka <[email protected]>
remote-organization-name: bucketeer-io | ||
remote-repository-name: bucketeer-cla | ||
path-to-signatures: "cla/signatures.json" | ||
custom-notsigned-prcomment: "Welcome!\nThanks for your contribution. It looks like this is your first PR to this repository 🎉. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Please read the [CLA](https://github.com/bucketeer-io/bucketeer/blob/main/CLA.md) and leave a below comment on this pull request to sign the CLA." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the CLA.md file to this repository instead of the core one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you tell me why we need another CLA file for this repository? I think it is easy to maintain to have only one CLA file.
Do you want to have independent CLA file and signatures.json for each repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to have independent CLA file and signatures.json for each repository?
I understand that the signatures.json
supports multiple repositories.
The reason is that this repository has no reference to the CLA terms. So how can you sign something that you can't check the terms?
Another reason that I didn't add the CLA to the SDK repositories is that we might not need it.
PipeCD has removed it. You can check the conversation here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got it. Groups cannot be an legal entity🤔 Then, let's remove CLA from bucketeer-io org 👍
uses: contributor-assistant/github-action@a895a435fcce79ecf28fbce61a4ef0f0dabc9853 # v2.3.1 | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
PERSONAL_ACCESS_TOKEN: ${{ secrets.CLA_PAT }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please set the CLA_PAT
secret.
CLA is not necessary. See here. |
No description provided.