Add connect-dart plugin #1638
Add connect-dart plugin #1638
Conversation
Signed-off-by: Sri Krishna Paritala <[email protected]>
Signed-off-by: Sri Krishna Paritala <[email protected]>
| FROM dart:3.5.4-sdk AS build | ||
|
|
||
| WORKDIR /build | ||
| RUN curl -fsSL https://github.com/connectrpc/connect-dart/archive/refs/tags/v0.1.0.tar.gz --compressed -o connect-dart.tar.gz \ |
There was a problem hiding this comment.
We are not downloading from pub.dev like the base types plugin because dart is unable to resolve dependencies because of the relative dev dependency. This is a fairly common practice.
plugins/connectrpc/dart/source.yaml
Outdated
| @@ -0,0 +1,3 @@ | |||
| source: | |||
| dart_flutter: | |||
| name: connectrpc | |||
There was a problem hiding this comment.
Double-checking, I presume we will be publishing to pub.dev?
There was a problem hiding this comment.
In other words, is this the correct place to look for new releases instead of just github?
There was a problem hiding this comment.
There was an issue with pub.dev see #1638 (comment)
| @@ -0,0 +1,16 @@ | |||
| # syntax=docker/dockerfile:1.4 | |||
| FROM dart:3.5.4-sdk AS build | |||
There was a problem hiding this comment.
What is the best way to know which dart version we should support?
Asking because there's an upstream issue where the directive is still at 2.x
Part of the reason we haven't updated this yet, e.g.,
https://github.com/bufbuild/plugins/blob/main/plugins/protocolbuffers/dart/v21.1.2/Dockerfile#L2
There was a problem hiding this comment.
pubspec.yaml files have the dart sdk range specified, as long as it satisfies that we should be able to upgrade
There was a problem hiding this comment.
Okay great, then we should be able to update the latest base types to the latest dart 3 version. That way we can keep both dart plugins on the same version.
Signed-off-by: Sri Krishna Paritala <[email protected]>
Co-authored-by: Michael Fridman <[email protected]>
Signed-off-by: Sri Krishna Paritala <[email protected]>
Add connect-dart plugin