Merge branch 'better_backups' into futures_dev

bug-or-feature · Jan 31, 2025 · ecd4c59 · ecd4c59
2 parents dbbe91a + 5605119
commit ecd4c59
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/sysdata/config/defaults.yaml b/sysdata/config/defaults.yaml
@@ -27,6 +27,8 @@ backtest_max_age: 30
 # And backups
 csv_backup_directory: 'data.backups_csv'
 mongo_dump_directory: 'data.mongo_dump'
+# if mongo_dump_all is True, we dump all databases, otherwise just PST dbs
+mongo_dump_all: True
 echo_directory: 'data.echos'
 offsystem_backup_options: '-av'
 #

diff --git a/sysproduction/backup_mongo_data_as_dump.py b/sysproduction/backup_mongo_data_as_dump.py
@@ -34,11 +34,25 @@ def dump_mongo_data(data: dataBlob):
     config = data.config
     host = config.get_element_or_arg_not_supplied("mongo_host")
     path = get_mongo_dump_directory()
-    data.log.debug("Dumping mongo data to %s NOT TESTED IN WINDOWS" % path)
     if host.startswith("mongodb://"):
-        os.system("mongodump --uri='%s' -o=%s" % (host, path))
+        source = "uri"
     else:
-        os.system("mongodump --host='%s' -o=%s" % (host, path))
+        source = "host"
+
+    dump_all = config.get_element_or_default("mongo_dump_all", True)
+    if dump_all:
+        data.log.debug(f"Dumping ALL mongo data to {path} (NOT TESTED IN WINDOWS)")
+        os.system(f"mongodump --{source}='{host}' -o={path}")
+
+    else:
+        db_name = config.get_element("mongo_db")
+        data.log.debug(
+            f"Dumping mongo data from {db_name} to {path} (NOT TESTED IN WINDOWS)"
+        )
+        os.system(f"mongodump --{source}='{host}' -o={path} --db={db_name}")
+        # will silently fail if arctic db does not exist
+        os.system(f"mongodump --{source}='{host}' -o={path} --db=arctic_{db_name}")
+
     data.log.debug("Dumped")