Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUP-2750 Error if pipeline doesn't exist #402

Merged
merged 1 commit into from
Nov 24, 2024
Merged

SUP-2750 Error if pipeline doesn't exist #402

merged 1 commit into from
Nov 24, 2024

Conversation

mcncl
Copy link
Contributor

@mcncl mcncl commented Nov 24, 2024

Changes

  • In Incomplete Build Created Output #397 the issue was raised that bk new --pipeline will just output a blank URL
  • This is because the error is on the spinner.Run() rather than checking the API response
  • This PR fixes that by checking the API response and outputting the correct API error message

@mcncl mcncl changed the title Error if pipeline doesn't exist SUP-2750 Error if pipeline doesn't exist Nov 24, 2024
@mcncl mcncl merged commit e841ded into main Nov 24, 2024
1 check passed
@mcncl mcncl deleted the bm/error_no_pipeline_found branch November 24, 2024 23:57
@mcncl mcncl mentioned this pull request Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizrabuya lizrabuya lizrabuya approved these changes

@PriyaSudip PriyaSudip Awaiting requested review from PriyaSudip PriyaSudip is a code owner

@jykingston jykingston Awaiting requested review from jykingston jykingston is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcncl @lizrabuya