Add WithTimeout() and TryUntil() config options #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moskyb
commented
Nov 30, 2022
| @@ -112,6 +112,23 @@ func TestShouldGiveUp_WithMaxAttempts(t *testing.T) { | |||
| assert.Equal(t, 3, callcount) | |||
| } | |||
|
|
|||
| func TestTimeout(t *testing.T) { | |||
There was a problem hiding this comment.
this test super doesn't work, because the timeout function measures time inside the callback as well as time outside the callback (ie time spent waiting). The call count flakes between 92 and 93 before the timeout completes
moskyb
commented
Nov 30, 2022
| @@ -275,6 +314,8 @@ func (r *Retrier) sleepOrDone(ctx context.Context, nextInterval time.Duration) e | |||
| close(sleepCh) | |||
| }() | |||
| select { | |||
| case <-timeouter.C: | |||
| return fmt.Errorf("retrier timed out after %v", r.timeout) | |||
There was a problem hiding this comment.
possibly this should be a public error value so that people can test for errors.Is(err, roko.TimeoutExceeded) or something
moskyb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: Adds functionality to make roko retry against a timeout, as well as a max attempt count. Note that this is independent of using a context with a timeout and
retrier.DoWithContext(), which will also work fine. This PR just exposes similar features through a more fluent API.We expose this through the
WithTimeout(time.Duration)andUntil(time.Time)config functions.Still to do:
Until()should be calledTryUntil()for symmetry withTryForever()?WithSleepFuncstuff that we've been using in other tests, as the timer that timeouts run on are out fo band from the normal sleep process. Would love to hear some ideas on how to test this functionality nicely