Add ability to save test results to disk #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwidiapradja
force-pushed
the
tech/local-result-storage
branch
from
c830440 to
43100d7
Compare
pda
reviewed
Jan 23, 2025
| @@ -72,6 +72,7 @@ extension EnvironmentValues { | |||
| var analyticsBaseURL: URL? { self.url(for: "BUILDKITE_ANALYTICS_BASE_URL") } | |||
|
|
|||
| var isAnalyticsDebugEnabled: Bool { self.bool(for: "BUILDKITE_ANALYTICS_DEBUG_ENABLED") ?? false } | |||
| var isAnalyticsCachingEnabled: Bool { self.bool(for: "BUILDKITE_ANALYTICS_CACHING_ENABLED") ?? true } | |||
| } | ||
|
|
||
| private func saveTestData(_ testData: TestResults) throws { | ||
| try fileController.saveData(testData, fileName: "TestResults-\(UUID().uuidString)", fileExtension: "json") |
There was a problem hiding this comment.
I wonder if a timestamp near the left of the filename would be useful for sort order, and to differentiate e.g. todays results from stale results sitting around?
Comment on lines
+44
to
+45
| /// Whether caching is enabled. | ||
| var isCacheEnabled: Bool |
There was a problem hiding this comment.
I'm not sure about calling this “cache” 🤔
I figure cache is generally an additional layer of storage, often for performance, and the cache subsystem manages writing and reading from that store.
Whereas this feels like an output mode; it's storing data in a location for some other process to pick up later (for subsequent out-of-band uploading).
Maybe it's “store local files” e.g. isStoreLocalFilesEnabled?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💬 Summary of Changes
trueinto a new environment value ofBUILDKITE_ANALYTICS_CACHING_ENABLED. When this value isfalse, traces won't be recorded and will also prevent data from being written to disk .jsonfile, containing the data that would otherwise be sent over to the API.🧾 Checklist
📝 Items of Note
Due to the app sandbox restrictions, test results can't be written to an arbitrary folder in the macOS file systems when unit tests are being run on Xcode simulators. As such, test results are saved in the app container's directory, in
Documents/BuildkiteTestCollector.