add comment

buntec · Feb 7, 2024 · 145a479 · 145a479
1 parent 881c82b
commit 145a479
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/snabbdom/src/main/scala/snabbdom/modules/Props.scala b/snabbdom/src/main/scala/snabbdom/modules/Props.scala
@@ -86,6 +86,13 @@ object Props {
       }
     }
 
+    // TODO: remove altogether?
+    // This is mostly futile b/c it only removes
+    // Own properties while properties of
+    // DOM elements are typically inherited.
+    // E.g., a prop like `id` cannot be deleted
+    // (removing the corresponding (reflected) attribute
+    // sets this property to the empty string).
     oldProps.foreach { case (key, _) =>
       if (!props.contains(key)) {
         elm.asInstanceOf[js.Dictionary[Any]] -= key