Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: enabling sqs event processing #2

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

kuntalkumarbasu
Copy link
Contributor

Enabling sqs event handling for this lambda

Copy link
Contributor

@rtyler rtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change breaks the existing behavior of the Lambda as I believe it will result in S3 Event Notifications not being received properly when triggering the Lambda directly as opposed to via SQS

I presume you wish to have SQS support because you're using S3 Event Notifications -> SNS and then fanning out to multiple SQSes?

Cargo.toml Outdated Show resolved Hide resolved
Co-authored-by: R. Tyler Croy <[email protected]>
@kuntalkumarbasu
Copy link
Contributor Author

This change breaks the existing behavior of the Lambda as I believe it will result in S3 Event Notifications not being received properly when triggering the Lambda directly as opposed to via SQS

I presume you wish to have SQS support because you're using S3 Event Notifications -> SNS and then fanning out to multiple SQSes?

@rtyler yes, you are probably right. it will not recieve s3 event notification at all. How do you suggest we proceed with it where it is compatible with both kind of potential event

@rtyler rtyler merged commit 66b0c34 into buoyant-data:main Mar 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants