Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed status bar not displaying termination UI #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed status bar not displaying termination UI #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/status-bar.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ class StatusBar extends View
returnFocus: null

@content: ->
@div class: 'termination status-bar', tabindex: -1, =>
@div class: 'termination inline-block', tabindex: -1, =>
Copy link
Member

@the-j0k3r the-j0k3r Nov 3, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no actual less/CSS class inline-block defined, so technically this is breaking something, it would probably work by removing it you can test this easily if by removing it would also fix issue.

removing

Termination/styles/termination.less

Line 105 in f588e7c

&.status-bar {
really needs to be considered.

If removing it ( just leave termination in these changes) fixes the issue, then it probably means this should be fixed some other way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fred-Barclay ping.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@the-j0k3r @qub1750ul sorry I'll check this soon

@i class: "icon icon-plus", click: 'newTerminalView', outlet: 'plusBtn'
@ul class: "list-inline status-container", tabindex: '-1', outlet: 'statusContainer', is: 'space-pen-ul'
@ul class: "inline-block list-inline status-container", tabindex: '-1', outlet: 'statusContainer', is: 'space-pen-ul'
@i class: "icon icon-x", click: 'closeAll', outlet: 'closeBtn'

initialize: (@statusBarProvider) ->
Expand Down