Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate env variables to shell subprocess to respect PATH #58

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Propagate env variables to shell subprocess to respect PATH #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion django_migrations_ci/shell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import logging
import os
from subprocess import PIPE, Popen

logger = logging.getLogger(__name__)
Expand All @@ -10,13 +11,18 @@ class MigrateCIShellException(Exception):

def exec(command, env=None):
logger.info(f"Running shell command {command}")

subprocess_env = os.environ.copy()
if env:
subprocess_env.update(env)

p = Popen(
command,
shell=True,
stdin=PIPE,
stdout=PIPE,
stderr=PIPE,
env=env,
env=subprocess_env,
)
stdout, stderr = p.communicate()
if stderr:
Expand Down
Loading