sixel support #423
Merged
sixel support #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butlerx
approved these changes
Aug 18, 2022
|
You'll need to add the worker file to the prettier and eslint ignore to pass tests |
|
@butlerx Reverted to the asset copy solution and added ingore files for eslint and prettier. This is still subpar, as it involves manual interaction once the package version was changed (file needs to be copied over again). Seems the tests wont run without your approval? |
|
Thanks @jerch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May fix #422.
@butlerx Well plz see the comments in source file - since I dont quite grasped your build layout I simply added the worker file to assets, which is prolly not the way to do it.