Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asserting wchar_t strings #37

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Asserting wchar_t strings #37

wants to merge 4 commits into from

Conversation

Isty001
Copy link
Contributor

@Isty001 Isty001 commented Sep 17, 2018

Hello,

This PR adds another assertion, same as ASSERT_STR but accepts and compares wchar_t * types instead of char *.

@bvdberg
Copy link
Owner

bvdberg commented May 23, 2019

merged

@bvdberg bvdberg closed this May 23, 2019
@bvdberg
Copy link
Owner

bvdberg commented May 23, 2019

what issue did you run into to need the sanitizer attribute?

@bvdberg bvdberg reopened this May 23, 2019
@Isty001
Copy link
Contributor Author

Isty001 commented May 24, 2019

Oh, sorry, originally I didn't want to include that in the PR. I get the following report:

==16618==ERROR: AddressSanitizer: global-buffer-overflow on address 0x555af21e1d1c at pc 0x555af1fae6c4 bp 0x7ffcfd09d020 sp 0x7ffcfd09d010
READ of size 4 at 0x555af21e1d1c thread T0
    #0 0x555af1fae6c3 in ctest_main deps/ctest/ctest.h:483
...
Address 0x555af21e1d1c is a wild pointer.
SUMMARY: AddressSanitizer: global-buffer-overflow deps/ctest/ctest.h:483 in ctest_main

Compiler: gcc
Sanitizer flags: -fsanitize=address -fsanitize=leak -fsanitize=undefined

Unfortunately I couldn' solve the problem yet, but had to disable the check for that function to debug the actual code I'm testing.

@bvdberg
Copy link
Owner

bvdberg commented May 24, 2019

I don't think it will break anything.. maybe more people can test it.. (mac?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants