Issue-172 query runner version and fix ruby bug Issue-162 #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite receiving arguments, the method must guarantee to return the same value always. Only then the constant decorator makes sense. If the method may return different values for different inputs (arguments), it would be better to use `functools.lru_cache`. The advantage of `constant` over `functools.lru_cache` is it is thread-safe and `byexample`'s concurrency model is aware of it.
When using `subprocess.call` and similar, the API requires a list with the program name and its arguments. ShebangTemplate has the correct position to offer that easily.
The method should return the version of the underlying interpreter/runner as a tuple if possible. If no version can be detected, it should return None (which it is the default).
We found that in irb >= 1.2.0 the interpreter outputs nonsense. The use of `-f`, `--nomultiline`, `--nocolorize` and `--noreadline` fixes the problem (suggested by @fnordfish). Because `--nomultiline` and `--nocolorize` are not valid options for irb < 1.2.0, we require to detect the version of irb to properly choose the correct options. Closes #162 and closes #172
This maintains backward-compatibility with the irb < 1.2.0 behavior.
eldipa
force-pushed
the
Issue-172-Query-Runner-Version
branch
from
336a9d5 to
cc226a7
Compare
Allow the user to control if he/she wants the older behavior of irb (and default for byexample) or the new one where a newline is added after the => marker when the output is large. To maintain backward compatibility, byexamples sets this flag to false. This closes #162.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #172 and closes #162