Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wording about javy compile in help text #814

Merged
merged 1 commit into from
Nov 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions crates/cli/src/commands.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ pub enum Command {
///
/// NOTICE:
///
/// This command will be deprecated in
/// the next major release of the CLI (v4.0.0)
/// This command is deprecated and will be removed.
///
/// Refer to https://github.com/bytecodealliance/javy/issues/702 for
/// details.
Expand Down
3 changes: 1 addition & 2 deletions crates/cli/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ fn main() -> Result<()> {
Command::Compile(opts) => {
eprintln!(
r#"
The `compile` command will be deprecated in the next major
release of the CLI (v4.0.0)
The `compile` command is deprecated and will be removed.

Refer to https://github.com/bytecodealliance/javy/issues/702 for
details.
Expand Down
6 changes: 3 additions & 3 deletions crates/test-macros/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -285,9 +285,9 @@ fn expand_cli_tests(test_config: &CliTestConfig, func: syn::ItemFn) -> Result<To
);

let preload_setup = if test_config.dynamic {
// The compile commmand will remain frozen until it becomes
// deprecated in Javy v4.0.0. Until then we test with a frozen
// artifact downloaded from the releases.
// The compile commmand will remain frozen until it is deleted.
// Until then we test with a frozen artifact downloaded from the
// releases.
if command_name == "Compile" {
quote! {
let root = std::path::PathBuf::from(env!("CARGO_MANIFEST_DIR"));
Expand Down
Loading