feat(examples): add browser fetch() example #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This example adds a component that uses browser-provided `fetch()` (and related shims) which returns the response for a GET request to a given URL. This example should showcase how to use a transpiled component with fetch from the browser context. Currently, the example builds and tranpsiles the component but *does not* test it, as we need code in the async support PR to land first. Signed-off-by: Victor Adossi <[email protected]>
|
Great to see, although yes we shouldn't include examples that depend on unreleased features I think unfortunately. For browser examples, we are likely stuck with sync WebIDL examples mostly for now, but would still be great to see something here further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example adds a component that uses browser-provided
fetch()(and related shims) which returns the response for a GET request to a given URL.This example should showcase how to use a transpiled component with fetch from the browser context.
Currently, the example builds and tranpsiles the component but does not test it, as we need code in the async support PR to land first.
Thanks @cytommi for finding, reporting and diagnosing this bug!
While fetch is being translated at the engine level, the lacking implementation of
wasi:http/typesis causingRequest.sendto not actually get called properly.