Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix std feature in wasm-encoder #1961

Merged
merged 7 commits into from
Jan 22, 2025

Conversation

ark0f
Copy link
Contributor

@ark0f ark0f commented Dec 20, 2024

No description provided.

@alexcrichton
Copy link
Member

Thanks for the PR! Could you describe a bit more what's going on here? I'm not sure what the fix is and I'm also not familiar enough with the leb128fmt crate to know how best it solves such a problem off the top of my head.

@ark0f
Copy link
Contributor Author

ark0f commented Jan 21, 2025

Could you describe a bit more what's going on here?

I found out that wasm-encoder does not switch std feature of its wasmparser dependency after #1938. I also disabled std feature in the workspace for wasmparser (and wasm-encoder for consistency) so it can manage this feature properly.

I'm also not familiar enough with the leb128fmt crate

leb128 doesn't support no-std when leb128fmt does

@alexcrichton
Copy link
Member

Ok sounds good, thanks! Can you update CI configuration around here to check that wasm-encoder builds for no_std? Looks like we forgot that from before which is why this wasn't caught earlier.

I'll take some time tomorrow to review the leb128fmt crate as well as we want to review new dependencies before including them.

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your work here!

@alexcrichton alexcrichton added this pull request to the merge queue Jan 22, 2025
Merged via the queue into bytecodealliance:main with commit 7530629 Jan 22, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants