Support fetching imports from a Module #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saulecabrera
reviewed
Sep 9, 2024
ext/src/ruby_api/module.rs
Outdated
| let hash = RHash::new(); | ||
| hash.aset("module", import.module())?; | ||
| hash.aset("name", import.name())?; | ||
| hash.aset("type", format!("{:?}", import.ty()))?; |
There was a problem hiding this comment.
I'm not sure we want to return a string for the type, ideally we'd want a proper type representing the extern. I believe you can use https://github.com/bytecodealliance/wasmtime-rb/blob/main/ext/src/ruby_api/externals.rs#L110
davejcameron
force-pushed
the
module-imports
branch
from
65015be to
5179dd9
Compare
ext/src/ruby_api/externals.rs
Outdated
| /// @yard | ||
| /// Returns the exported function's FuncType or raises a `{ConversionError}` when the export is not a | ||
| /// function. | ||
| /// @return [Func] The exported function. |
There was a problem hiding this comment.
I believe here it should be
@return [FuncType]
In the signatures below as well?
saulecabrera
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for fetching the list of Module imports.