pulley: Ungate the GC_TYPES feature from Pulley #9785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
requested review from
abrown and
fitzgen
and removed request for
a team
|
Note this is currently based on #9780 |
fitzgen
approved these changes
Dec 11, 2024
| ;;;; Rules for `bor` ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; | ||
|
|
||
| (rule 0 (lower (has_type (fits_in_32 _) (bor a b))) | ||
| (pulley_xor32 a b)) |
There was a problem hiding this comment.
This is a somewhat unfortunate instruction name :-/
There was a problem hiding this comment.
Heh good eye! I didn't even realize this until I added lowerings for bxor later and wrote pulley_xxor. In a future PR I'll rename this to pulley_xbor32 to make room for the actual xor op.
Similar to bytecodealliance#9779 this remove the `GC_TYPES` feature from the list of panicking features in Pulley. In doing so this then additionally fixes a number of panics and then adds more tests that are working. Some other minor instructions are filled out to ensure that tests are working on both 32 and 64-bit platforms.
alexcrichton
force-pushed
the
pulley-gc-types
branch
from
e222eb3 to
4b01672
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #9779 this remove the
GC_TYPESfeature from the list ofpanicking features in Pulley. In doing so this then additionally fixes a
number of panics and then adds more tests that are working. Some other
minor instructions are filled out to ensure that tests are working on
both 32 and 64-bit platforms.
cc #9783