Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulley: More division/remainder instructions #9791

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Dec 11, 2024

Gets a few misc tests passing

cc #9783

Gets a few misc tests passing
@alexcrichton alexcrichton requested review from a team as code owners December 11, 2024 19:19
@alexcrichton alexcrichton requested review from cfallin and fitzgen and removed request for a team December 11, 2024 19:19
(rule (lower (has_type $I32 (udiv a b))) (pulley_xdiv32_u a b))
(rule (lower (has_type $I64 (udiv a b))) (pulley_xdiv64_u a b))

;;;; Rules for `srem` ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this comment be urem?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, yes!

@alexcrichton alexcrichton added this pull request to the merge queue Dec 11, 2024
Merged via the queue into bytecodealliance:main with commit 65312bf Dec 11, 2024
43 checks passed
@alexcrichton alexcrichton deleted the pulley-divrem branch December 11, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants