Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose component model in C api #9812

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Expose component model in C api #9812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66c1d4e
Expose component-model to c-api
rockwotj Jan 15, 2024
e1d1880
Allow definition of host callbacks in c-api component-model
lanfeust69 Dec 10, 2024
9dbce5c
Add documentation and example
lanfeust69 Dec 10, 2024
f14d457
Fix CI
lanfeust69 Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/c-api/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ logging = ['dep:env_logger']
disable-logging = ["log/max_level_off", "tracing/max_level_off"]
coredump = ["wasmtime/coredump"]
addr2line = ["wasmtime/addr2line"]
component-model = ["wasmtime/component-model", "cranelift"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally the component-model feature wouldn't necessarily imply cranelift, so would it be ok to gate some functions (e.g. component compilation) behind both features?

demangle = ["wasmtime/demangle"]
threads = ["wasmtime/threads"]
gc = ["wasmtime/gc"]
Expand Down
2 changes: 2 additions & 0 deletions crates/c-api/artifact/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ default = [
'gc-null',
'cranelift',
'winch',
'component-model',
# ... if you add a line above this be sure to change the other locations
# marked WASMTIME_FEATURE_LIST
]
Expand All @@ -52,6 +53,7 @@ coredump = ["wasmtime-c-api/coredump"]
addr2line = ["wasmtime-c-api/addr2line"]
demangle = ["wasmtime-c-api/demangle"]
wat = ["wasmtime-c-api/wat"]
component-model = ["wasmtime-c-api/component-model"]
threads = ["wasmtime-c-api/threads"]
gc = ["wasmtime-c-api/gc"]
gc-drc = ["wasmtime-c-api/gc-drc"]
Expand Down
1 change: 1 addition & 0 deletions crates/c-api/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ const FEATURES: &[&str] = &[
"GC_NULL",
"CRANELIFT",
"WINCH",
"COMPONENT_MODEL",
];
// ... if you add a line above this be sure to change the other locations
// marked WASMTIME_FEATURE_LIST
Expand Down
1 change: 1 addition & 0 deletions crates/c-api/cmake/features.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,6 @@ feature(gc-null ON)
feature(async ON)
feature(cranelift ON)
feature(winch ON)
feature(component-model ON)
# ... if you add a line above this be sure to change the other locations
# marked WASMTIME_FEATURE_LIST
Loading
Loading