Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement simd_i32x4_arith2 for pulley #9907

Merged
merged 1 commit into from
Dec 29, 2024
Merged

feat: Implement simd_i32x4_arith2 for pulley #9907

merged 1 commit into from
Dec 29, 2024

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Dec 28, 2024

Part of #9783

This PR adds the following instructions for pulley:

  • vmin32x4_s
  • vmin32x4_u
  • vmax32x4_s
  • vmax32x4_u
  • vabs32x4

which helped pass the simd_i32x4_arith2 test.

@Xuanwo Xuanwo requested review from a team as code owners December 28, 2024 05:28
@Xuanwo Xuanwo requested review from fitzgen and removed request for a team December 28, 2024 05:28
@Xuanwo Xuanwo mentioned this pull request Dec 28, 2024
Open
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator pulley Issues related to the Pulley interpreter labels Dec 28, 2024
@github-actions GitHub Actions
Copy link

Subscribe to Label Action

cc @fitzgen

This issue or pull request has been labeled: "cranelift", "pulley"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: pulley

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

alexcrichton
alexcrichton approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexcrichton alexcrichton added this pull request to the merge queue Dec 29, 2024
Merged via the queue into bytecodealliance:main with commit 54b7250 Dec 29, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

@fitzgen fitzgen Awaiting requested review from fitzgen fitzgen is a code owner automatically assigned from bytecodealliance/wasmtime-compiler-reviewers

Assignees
No one assigned
Labels
cranelift Issues related to the Cranelift code generator pulley Issues related to the Pulley interpreter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xuanwo @alexcrichton