-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the memory64 proposal by default #9937
base: main
Are you sure you want to change the base?
Conversation
The memory64 proposal for WebAssembly moved to phase 4 early last November which was the final remaining blocker for enabling it in Wasmtime. I've gone ahead and enabled it here with all the other checkboxes being ticked such as: * Tests - all spec tests are enabled and we have a few tests here and there for memory64 behavior throughout the unit test suite. * Finished - this proposal's memory-facing bits have been done for quite some time and the final 64-bit table bits have been done for a bit now as well. * Fuzzed - this is enabled in `wasm-smith` and additionally has custom fuzzing via the `memory_accesses` fuzzer. * API - all APIs related to memory work with `u64` values to accommodate 64-bit memories and the 64-bit-ness is reflected in the type of memories. * C API - the C API's functions for working with memories all reflect 64-bit indices like the Rust API.
Label Messager: wasmtime:configIt looks like you are changing Wasmtime's configuration options. Make sure to
To modify this label's message, edit the To add new label messages or remove existing label messages, edit the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do we need to do anything special (that hasn't already been done) to indicate that memory64 is not yet compatible with components? Or will that be caught by wasmparser
at validation time?
Oh you know that's a good point. I haven't checked up on the state of memory64 and components in awhile. I know some parts support some things but not all, and I suspect that there are a number of memory64-related panics in Wasmtime which I should convert to errors first before landing this. |
On review looks like less has support for this than I thought. I've opted to go with a wasmparser validation change for now since components don't currently specify how everything works anyway. |
The memory64 proposal for WebAssembly moved to phase 4 early last November which was the final remaining blocker for enabling it in Wasmtime. I've gone ahead and enabled it here with all the other checkboxes being ticked such as:
Tests - all spec tests are enabled and we have a few tests here and there for memory64 behavior throughout the unit test suite.
Finished - this proposal's memory-facing bits have been done for quite some time and the final 64-bit table bits have been done for a bit now as well.
Fuzzed - this is enabled in
wasm-smith
and additionally has custom fuzzing via thememory_accesses
fuzzer.API - all APIs related to memory work with
u64
values to accommodate 64-bit memories and the 64-bit-ness is reflected in the type of memories.C API - the C API's functions for working with memories all reflect 64-bit indices like the Rust API.