Skip to content
This repository has been archived by the owner on Oct 3, 2024. It is now read-only.

group.Order() now returns bytes, scalar.MinusOne() sets to order-1 #68

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

bytemare
Copy link
Owner

@bytemare bytemare commented Oct 1, 2024

No description provided.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.59%. Comparing base (5fb54db) to head (b19ae7c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/edwards25519/scalar.go 90.90% 0 Missing and 1 partial ⚠️
internal/ristretto/scalar.go 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   91.44%   91.59%   +0.14%     
==========================================
  Files          19       19              
  Lines        1473     1475       +2     
==========================================
+ Hits         1347     1351       +4     
+ Misses         72       71       -1     
+ Partials       54       53       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: bytemare <[email protected]>
Signed-off-by: bytemare <[email protected]>
Copy link

sonarqubecloud bot commented Oct 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
22.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@bytemare bytemare merged commit b2be839 into main Oct 2, 2024
15 of 16 checks passed
@bytemare bytemare deleted the order-bytes-minus-one branch October 2, 2024 00:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant