Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-ordering the pull request template #60

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Re-ordering the pull request template #60

merged 1 commit into from
Nov 22, 2023

Conversation

ineiti
Copy link
Member

@ineiti ineiti commented Nov 21, 2023

What about this beauty:

Thank you for opening a pull request with this project, please also:

  • add a brief description of your changes here
  • assign the PR to yourself, or to the person(s) working on it
  • start in draft mode and in progress pipeline in the project (if applicable)
  • if applicable, add this PR to its related issue by one of the special keywords Closing keywords
  • once it's ready
    • put it in the Review or Ready4Merge pipeline in the project (if applicable)
    • remove draft
    • assign a reviewer

@ineiti ineiti self-assigned this Nov 21, 2023
@ineiti ineiti force-pushed the pull-request-message branch from f1a791e to 8be8a70 Compare November 21, 2023 16:26
@PascalinDe
Copy link
Member

LGTM, can you update the file in the C4DT .github project as well? that's the file that will be used for new projects :)

@ineiti
Copy link
Member Author

ineiti commented Nov 22, 2023

LGTM, can you update the file in the C4DT .github project as well? that's the file that will be used for new projects :)

That's what is in this PR. I just copied the new pull_request_template.md to the PR comment to show how it'll look like.

@ineiti ineiti merged commit 6413da5 into main Nov 22, 2023
11 checks passed
@ineiti ineiti deleted the pull-request-message branch November 22, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants