Smaller changes, also undo of breaking change in PR #69 #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineiti
reviewed
Dec 12, 2023
web/frontend/tests/navbar.spec.ts
Outdated
| @@ -46,7 +47,7 @@ test('Assert admin user HAR files are up-to-date', async({ page }) => { | |||
| test('Assert cookie is set', async({ page }) => { | |||
| test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files'); | |||
| const cookies = await page.context().cookies(); | |||
| expect(cookies.find(cookie => cookie.name === 'connect.sid')).toBeTruthy(); | |||
| await expect(cookies.find(cookie => cookie.name === 'connect.sid')).toBeTruthy(); | |||
There was a problem hiding this comment.
I wonder whether that was why it failed before on my ocmputer? But there might be another async hidden somewhere.
web/frontend/tests/tsconfig.json
Outdated
| "skipLibCheck": true, | ||
| "esModuleInterop": true, | ||
| "allowSyntheticDefaultImports": true, | ||
| "strict": false, |
There was a problem hiding this comment.
What happens if you set this to true? That's the interesting option!
There was a problem hiding this comment.
I just copy-pasted the config from the "main" project, I will test that
There was a problem hiding this comment.
changed it, not much change for the moment, though that might be because I ran the linter and fixed everything beforehand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some smaller changes and an undo