Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix texts of clinical data pagination #4909

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

fuzhaoyuan
Copy link
Contributor

@fuzhaoyuan fuzhaoyuan commented May 9, 2024

This is a partial fix for cBioPortal/cbioportal#10770.
This address some of the sub-issues from the issue page, i.e.:

  1. Disable 'show more' when "maximum records" message appears
  2. Click 'Show more' also display the pagination text

The brokend table sorting hasn't been fixed yet. A re-testing would be helpful to double check if the issue persists. It can be also moved to a separate issue.

Copy link

netlify bot commented May 9, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 1930934
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/678acaefe797d50008d1c593
😎 Deploy Preview https://deploy-preview-4909.preview.cbioportal.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fuzhaoyuan fuzhaoyuan self-assigned this May 9, 2024
@fuzhaoyuan fuzhaoyuan force-pushed the clindata_filter_follow-up branch from f029412 to 76b2822 Compare May 10, 2024 14:22
@alisman alisman force-pushed the clindata_filter_follow-up branch from 76b2822 to 1930934 Compare January 17, 2025 21:26
@alisman alisman marked this pull request as ready for review January 17, 2025 21:51
@alisman alisman merged commit e9e68b6 into cBioPortal:master Jan 17, 2025
11 of 15 checks passed
@fuzhaoyuan fuzhaoyuan changed the title Clindata filter follow up Fix texts of clinical data pagination Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants