Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/10733: Updated default value of Timeline events availability chart #5066

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+0 −4
Open

Fix/10733: Updated default value of Timeline events availability chart #5066

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d24e92
fix default value of timeline events availability chart
ShahKirtan2003 Dec 14, 2024
bf472f2
Addressed review comment to remove changeChartVisibility condition
ShahKirtan2003 Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/studyView/StudyViewPageStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7816,7 +7816,7 @@ export class StudyViewPageStore
if (this.shouldDisplayClinicalEventTypeCounts.result) {
this.changeChartVisibility(
SpecialChartsUniqueKeyEnum.CLINICAL_EVENT_TYPE_COUNTS,
true
false
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahKirtan2003 wondering if this whole block can be removed? I guess the default is to hide the chart?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @inodb, removing the changeChartVisibility block is the same as setting false value. Addressed your suggestion in latest commit.

this.chartsType.set(
SpecialChartsUniqueKeyEnum.CLINICAL_EVENT_TYPE_COUNTS,
Expand Down