Fix # Issue with gene-panel-data/fetch API When molecularProfileIds is Empty [Issue 11252]

[jonkiky]

Fix # Issue with gene-panel-data/fetch API When molecularProfileIds is Empty
Related issue ticket: #11252

There is an issue when using the API gene-panel-data/fetch with an empty molecularProfileIds array as the request payload, it returns error.

Describe changes proposed in this pull request:

• The fix allows to pass in empty molecularProfileIds and response empty list .

[Aiosa]

I did similar thing to fix the checker:

BBMRI-ERIC/cbioportal@8636b4a#diff-1054b9ebb643fc3312ccec2bec08d82d9e28f9249024817405fd16ded9023a5fR93

However, I had to also extend endpoint to allow query to request 0 identifiers

BBMRI-ERIC/cbioportal@8636b4a#diff-1054b9ebb643fc3312ccec2bec08d82d9e28f9249024817405fd16ded9023a5fR93

Note that github seems to be having issue with direct links to rows, so you might need to search for relevant lines in the GenePanelDataMultipleStudyFilter.java and GenePanelDataController.java

[alisman]

@jonkiky which PR should i merge? this one or @Aiosa ?

[Aiosa]

Well, this PR does not account for modifications in the API (annotation to allow empty gene panel query).

[Aiosa]

it would be nicer to call the endpoint once, store it to a variable and test against it - a function call might be unnecessarily expensive.

[Aiosa]

also here

[Aiosa]

@jonkiky also I am not sure how this fix worked for you, but the API has to also enable zero-query panels, e.g.

public class GenePanelDataMultipleStudyFilter implements Serializable {

    -  @Size(min = 1, max = PagingConstants.MAX_PAGE_SIZE)
    +  @Size(min = 0, max = PagingConstants.MAX_PAGE_SIZE)
    private List<SampleMolecularIdentifier> sampleMolecularIdentifiers;
    -  @Size(min = 1, max = PagingConstants.MAX_PAGE_SIZE)
    +  @Size(min = 0, max = PagingConstants.MAX_PAGE_SIZE)
    private List<String> molecularProfileIds;

So if you fix these, it should be ready to go. Otherwise we will create new PR and submit the fix elsehwere.