prevent unnecessary rerenders

cBioPortal · Dec 17, 2024 · 31a789a · 31a789a
1 parent adbb83f
commit 31a789a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/web/src/main/javascript/src/App.tsx b/web/src/main/javascript/src/App.tsx
@@ -19,6 +19,7 @@ import About from "./pages/About/About";
 function App() {
   const location = useLocation();
   const [searchParams, setSearchParams] = useSearchParams();
+  const version = searchParams.get("version");
 
   const [oncoTreeData, setOncoTreeData] = useState<OncoTreeNode>();
   const [oncoTree, setOncoTree] = useState<OncoTree>();
@@ -33,13 +34,12 @@ function App() {
   }
 
   useEffect(() => {
-    const version = searchParams.get('version');
     try {
       version ? fetchData(version) : fetchData(DEFAULT_VERSION);
     } catch {
       toast.error("Error fetching OncoTree data");
     }
-  }, [searchParams]);
+  }, [version]);
 
   useEffect(() => {
     if (location.pathname !== PageRoutes.HOME) {

diff --git a/...resources/static/assets/index-AYjgkqMV.js → ...resources/static/assets/index-DTFjQa8K.js b/...resources/static/assets/index-AYjgkqMV.js → ...resources/static/assets/index-DTFjQa8K.js
diff --git a/web/src/main/resources/static/index.html b/web/src/main/resources/static/index.html
@@ -5,7 +5,7 @@
     <link rel="icon" type="image/svg+xml" href="/assets/favicon-CLRaiHsg.svg" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>OncoTree</title>
-    <script type="module" crossorigin src="/assets/index-AYjgkqMV.js"></script>
+    <script type="module" crossorigin src="/assets/index-DTFjQa8K.js"></script>
     <link rel="stylesheet" crossorigin href="/assets/index-B7wOa-XQ.css">
   </head>
   <body>