fix lint issues

cBioPortal · Nov 21, 2024 · 77239cc · 77239cc
1 parent db89d7c
commit 77239cc
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 21 deletions.
diff --git a/web/src/main/javascript/src/components/SearchBar/SearchBar.tsx b/web/src/main/javascript/src/components/SearchBar/SearchBar.tsx
@@ -304,7 +304,7 @@ export default function SearchBar({
       );
     }
 
-    const getPreviousResult = () => {
+    const getPreviousResult = useCallback(() => {
       if (!resultsAndIndexDefined) {
         return;
       }
@@ -315,9 +315,9 @@ export default function SearchBar({
         }
         oncoTree?.focus(cancerTypeResults[newIndex]);
         setCancerTypeResultsIndex(newIndex);
-    }
+    }, [resultsAndIndexDefined])
 
-    const getNextResult = () => {
+    const getNextResult = useCallback(() => {
       if (!resultsAndIndexDefined) {
         return;
       }
@@ -331,9 +331,11 @@ export default function SearchBar({
         }
         oncoTree?.focus(cancerTypeResults[newIndex]);
         setCancerTypeResultsIndex(newIndex);
-    }
+    }, [resultsAndIndexDefined])
 
     useEffect(() => {
+      const prevButton = prevButtonRef.current;
+      const nextButton = nextButtonRef.current
       const prevButtonTouchHandler = (event: TouchEvent) => {
         getPreviousResult();
         event.preventDefault();
@@ -342,14 +344,14 @@ export default function SearchBar({
         getNextResult();
         event.preventDefault();
       };
-      prevButtonRef.current?.addEventListener("touchstart", prevButtonTouchHandler);
-      nextButtonRef.current?.addEventListener("touchstart", nextButtonTouchHandler)
+      prevButton?.addEventListener("touchstart", prevButtonTouchHandler);
+      nextButton?.addEventListener("touchstart", nextButtonTouchHandler)
 
       return () => {
-        prevButtonRef.current?.removeEventListener("touchstart", prevButtonTouchHandler);
-        nextButtonRef.current?.removeEventListener("touchstart", nextButtonTouchHandler);
+        prevButton?.removeEventListener("touchstart", prevButtonTouchHandler);
+        nextButton?.removeEventListener("touchstart", nextButtonTouchHandler);
       }
-    }, []);
+    }, [getNextResult, getPreviousResult]);
 
     return (
       <>

diff --git a/...resources/static/assets/index-D07rChaF.js → ...resources/static/assets/index-BpCjHjQC.js b/...resources/static/assets/index-D07rChaF.js → ...resources/static/assets/index-BpCjHjQC.js
diff --git a/web/src/main/resources/static/index.html b/web/src/main/resources/static/index.html
@@ -5,7 +5,7 @@
     <link rel="icon" type="image/svg+xml" href="/assets/favicon-DLSGxvBL.svg" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>OncoTree</title>
-    <script type="module" crossorigin src="/assets/index-D07rChaF.js"></script>
+    <script type="module" crossorigin src="/assets/index-BpCjHjQC.js"></script>
     <link rel="stylesheet" crossorigin href="/assets/index-B7wOa-XQ.css">
   </head>
   <body>