devenv: override temp dirs after nix develop #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`nix develop` overrides all of the temp directories, which causes problems for module evaluation after the shell, for example `devenv up`. The temporary `nix-shell-<hash>` directory it creates is also unsafe to use as it might be garbage collected at a later point. The previous solution was to pick up the `DEVENV_RUNTIME` var, but that is not safe for nested devenvs and does not solve the the tmpdir issue.
Deploying devenv with
|
| Latest commit: |
b32703d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://87e9435a.devenv.pages.dev |
| Branch Preview URL: | https://reset-tmpdir.devenv.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nix developoverrides all of the temp directories, which causes problems for module evaluation after the shell, for exampledevenv up.The temporary
nix-shell-<hash>directory it creates is also unsafe to use as it might be garbage collected at a later point.The previous solution was to pick up the
DEVENV_RUNTIMEvar, but that is not safe for nested devenvs and does not solve the the tmpdir issue.Fixes #1620.